feat(core): Add `disableAutoUpload` option to Expo plugin #6195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

antonis wants to merge 8 commits into main from feat/expo-disable-auto-upload

Open

feat(core): Add `disableAutoUpload` option to Expo plugin #6195

docs: Add changelog entry for disableAutoUpload

@sentry/warden / warden: find-bugs completed May 21, 2026 in 11m 12s

1 issue

find-bugs: Found 1 issue (1 medium)

Medium

`disableAutoUpload: false` does not remove the Gradle override added by a prior `true` run - `packages/core/plugin/src/withSentry.ts:21`

In withSentryAndroid.ts, modifyAppBuildGradle only adds project.ext.shouldSentryAutoUploadGeneral = { -> return false } and never removes it. If a developer sets disableAutoUpload: true, runs expo prebuild, then removes the flag (or sets it to false) and reruns prebuild, the override stays in android/app/build.gradle and source map / debug symbol uploads remain silently disabled. The same shape of bug also exists on iOS (SENTRY_DISABLE_AUTO_UPLOAD=true injected into existing build phases is never removed when the flag flips back to false), so the fix should be symmetric.

Also found at:

packages/core/plugin/src/withSentryAndroid.ts:43-52
packages/core/test/expo-plugin/modifyAppBuildGradle.test.ts:66-69
packages/core/plugin/src/withSentry.ts:71
packages/core/plugin/src/withSentry.ts:88
packages/core/test/expo-plugin/modifyXcodeProject.test.ts:128-133

_{⏱ 10m 6s · 674.0k in / 82.1k out · $2.81}

Annotations

Check warning on line 21 in packages/core/plugin/src/withSentry.ts

sentry-warden / warden: find-bugs

`disableAutoUpload: false` does not remove the Gradle override added by a prior `true` run

In `withSentryAndroid.ts`, `modifyAppBuildGradle` only adds `project.ext.shouldSentryAutoUploadGeneral = { -> return false }` and never removes it. If a developer sets `disableAutoUpload: true`, runs `expo prebuild`, then removes the flag (or sets it to `false`) and reruns prebuild, the override stays in `android/app/build.gradle` and source map / debug symbol uploads remain silently disabled. The same shape of bug also exists on iOS (`SENTRY_DISABLE_AUTO_UPLOAD=true` injected into existing build phases is never removed when the flag flips back to false), so the fix should be symmetric.

Check warning on line 52 in packages/core/plugin/src/withSentryAndroid.ts

sentry-warden / warden: find-bugs

[ACN-HC6] `disableAutoUpload: false` does not remove the Gradle override added by a prior `true` run (additional location)

In `withSentryAndroid.ts`, `modifyAppBuildGradle` only adds `project.ext.shouldSentryAutoUploadGeneral = { -> return false }` and never removes it. If a developer sets `disableAutoUpload: true`, runs `expo prebuild`, then removes the flag (or sets it to `false`) and reruns prebuild, the override stays in `android/app/build.gradle` and source map / debug symbol uploads remain silently disabled. The same shape of bug also exists on iOS (`SENTRY_DISABLE_AUTO_UPLOAD=true` injected into existing build phases is never removed when the flag flips back to false), so the fix should be symmetric.

Check warning on line 69 in packages/core/test/expo-plugin/modifyAppBuildGradle.test.ts

sentry-warden / warden: find-bugs

[ACN-HC6] `disableAutoUpload: false` does not remove the Gradle override added by a prior `true` run (additional location)

In `withSentryAndroid.ts`, `modifyAppBuildGradle` only adds `project.ext.shouldSentryAutoUploadGeneral = { -> return false }` and never removes it. If a developer sets `disableAutoUpload: true`, runs `expo prebuild`, then removes the flag (or sets it to `false`) and reruns prebuild, the override stays in `android/app/build.gradle` and source map / debug symbol uploads remain silently disabled. The same shape of bug also exists on iOS (`SENTRY_DISABLE_AUTO_UPLOAD=true` injected into existing build phases is never removed when the flag flips back to false), so the fix should be symmetric.

Check warning on line 71 in packages/core/plugin/src/withSentry.ts

sentry-warden / warden: find-bugs

[ACN-HC6] `disableAutoUpload: false` does not remove the Gradle override added by a prior `true` run (additional location)

In `withSentryAndroid.ts`, `modifyAppBuildGradle` only adds `project.ext.shouldSentryAutoUploadGeneral = { -> return false }` and never removes it. If a developer sets `disableAutoUpload: true`, runs `expo prebuild`, then removes the flag (or sets it to `false`) and reruns prebuild, the override stays in `android/app/build.gradle` and source map / debug symbol uploads remain silently disabled. The same shape of bug also exists on iOS (`SENTRY_DISABLE_AUTO_UPLOAD=true` injected into existing build phases is never removed when the flag flips back to false), so the fix should be symmetric.

Check warning on line 88 in packages/core/plugin/src/withSentry.ts

sentry-warden / warden: find-bugs

[ACN-HC6] `disableAutoUpload: false` does not remove the Gradle override added by a prior `true` run (additional location)

In `withSentryAndroid.ts`, `modifyAppBuildGradle` only adds `project.ext.shouldSentryAutoUploadGeneral = { -> return false }` and never removes it. If a developer sets `disableAutoUpload: true`, runs `expo prebuild`, then removes the flag (or sets it to `false`) and reruns prebuild, the override stays in `android/app/build.gradle` and source map / debug symbol uploads remain silently disabled. The same shape of bug also exists on iOS (`SENTRY_DISABLE_AUTO_UPLOAD=true` injected into existing build phases is never removed when the flag flips back to false), so the fix should be symmetric.

Check warning on line 133 in packages/core/test/expo-plugin/modifyXcodeProject.test.ts

sentry-warden / warden: find-bugs

[ACN-HC6] `disableAutoUpload: false` does not remove the Gradle override added by a prior `true` run (additional location)

In `withSentryAndroid.ts`, `modifyAppBuildGradle` only adds `project.ext.shouldSentryAutoUploadGeneral = { -> return false }` and never removes it. If a developer sets `disableAutoUpload: true`, runs `expo prebuild`, then removes the flag (or sets it to `false`) and reruns prebuild, the override stays in `android/app/build.gradle` and source map / debug symbol uploads remain silently disabled. The same shape of bug also exists on iOS (`SENTRY_DISABLE_AUTO_UPLOAD=true` injected into existing build phases is never removed when the flag flips back to false), so the fix should be symmetric.

View more details on @sentry/warden