feat(core): Add disableAutoUpload option to Expo plugin
#6195
1 issue
code-review: Found 1 issue (1 medium)
Medium
Toggling `disableAutoUpload` from `true` back to `false` leaves stale `shouldSentryAutoUploadGeneral` override in `build.gradle` - `packages/core/plugin/src/withSentryAndroid.ts:41-50`
When disableAutoUpload was true in a previous prebuild and is then set to false, the shouldSentryAutoUploadGeneral = { -> return false } line already in the file is never removed — uploads remain silently disabled despite the user's intent to re-enable them.
Also found at:
packages/core/plugin/src/withSentryIOS.ts:71-77packages/core/test/expo-plugin/modifyXcodeProject.test.ts:142-148packages/core/plugin/src/withSentry.ts:71
⏱ 7m 28s · 349.2k in / 39.5k out · $1.42
Annotations
Check warning on line 50 in packages/core/plugin/src/withSentryAndroid.ts
sentry-warden / warden: code-review
Toggling `disableAutoUpload` from `true` back to `false` leaves stale `shouldSentryAutoUploadGeneral` override in `build.gradle`
When `disableAutoUpload` was `true` in a previous prebuild and is then set to `false`, the `shouldSentryAutoUploadGeneral = { -> return false }` line already in the file is never removed — uploads remain silently disabled despite the user's intent to re-enable them.
Check warning on line 77 in packages/core/plugin/src/withSentryIOS.ts
sentry-warden / warden: code-review
[88N-KNK] Toggling `disableAutoUpload` from `true` back to `false` leaves stale `shouldSentryAutoUploadGeneral` override in `build.gradle` (additional location)
When `disableAutoUpload` was `true` in a previous prebuild and is then set to `false`, the `shouldSentryAutoUploadGeneral = { -> return false }` line already in the file is never removed — uploads remain silently disabled despite the user's intent to re-enable them.
Check warning on line 148 in packages/core/test/expo-plugin/modifyXcodeProject.test.ts
sentry-warden / warden: code-review
[88N-KNK] Toggling `disableAutoUpload` from `true` back to `false` leaves stale `shouldSentryAutoUploadGeneral` override in `build.gradle` (additional location)
When `disableAutoUpload` was `true` in a previous prebuild and is then set to `false`, the `shouldSentryAutoUploadGeneral = { -> return false }` line already in the file is never removed — uploads remain silently disabled despite the user's intent to re-enable them.
Check warning on line 71 in packages/core/plugin/src/withSentry.ts
sentry-warden / warden: code-review
[88N-KNK] Toggling `disableAutoUpload` from `true` back to `false` leaves stale `shouldSentryAutoUploadGeneral` override in `build.gradle` (additional location)
When `disableAutoUpload` was `true` in a previous prebuild and is then set to `false`, the `shouldSentryAutoUploadGeneral = { -> return false }` line already in the file is never removed — uploads remain silently disabled despite the user's intent to re-enable them.