fix(tracing): Bound TTID/TTFD to prevent inflated transactions #6210
1 issue
code-review: Found 1 issue (1 medium)
Medium
Existing TTFD span status hardcoded to 'ok', bypassing deadline check - `packages/core/src/js/tracing/integrations/timeToDisplayIntegration.ts:144`
The addTimeToFullDisplay function still hardcodes ttfdSpan.status = 'ok' when updating an existing TTFD span, unlike the parallel fix applied to TTID in this PR — a deadline-exceeded TTFD span that already exists will be reported with status: 'ok' in Sentry.
Also found at:
packages/core/test/tracing/timetodisplay.test.tsx:295-337
⏱ 6m 14s · 652.9k in / 37.8k out · $1.37
Annotations
Check warning on line 144 in packages/core/src/js/tracing/integrations/timeToDisplayIntegration.ts
sentry-warden / warden: code-review
Existing TTFD span status hardcoded to 'ok', bypassing deadline check
The `addTimeToFullDisplay` function still hardcodes `ttfdSpan.status = 'ok'` when updating an existing TTFD span, unlike the parallel fix applied to TTID in this PR — a deadline-exceeded TTFD span that already exists will be reported with `status: 'ok'` in Sentry.
Check warning on line 337 in packages/core/test/tracing/timetodisplay.test.tsx
sentry-warden / warden: code-review
[5ZC-6JV] Existing TTFD span status hardcoded to 'ok', bypassing deadline check (additional location)
The `addTimeToFullDisplay` function still hardcodes `ttfdSpan.status = 'ok'` when updating an existing TTFD span, unlike the parallel fix applied to TTID in this PR — a deadline-exceeded TTFD span that already exists will be reported with `status: 'ok'` in Sentry.