Skip to content

feat(tracing): Wrap Expo Router push, replace, navigate, back, dismiss in addition to prefetch #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alwx merged 11 commits into from
Jun 3, 2026

fix(tracing): Drain pendingExpoRouterNavigation even when the idle-sp…

499ab39
Select commit
Loading
Failed to load commit list.
Merged

feat(tracing): Wrap Expo Router push, replace, navigate, back, dismiss in addition to prefetch #6221

fix(tracing): Drain pendingExpoRouterNavigation even when the idle-sp…
499ab39
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Jun 2, 2026 in 6m 44s

2 issues

code-review: Found 2 issues (1 medium, 1 low)

Medium

Stale `pendingExpoRouterNavigation` leaks to the next unrelated navigation span when `back()`/`dismiss()` is a no-op - `packages/core/src/js/tracing/expoRouter.ts:170-176`

When back() is called on an empty navigation stack (or dismiss() with nothing to dismiss), setPendingExpoRouterNavigation stores a pending value but React Navigation never fires a navigation action, so consumePendingExpoRouterNavigation in startIdleNavigationSpan is never called — the stale entry persists until the next unrelated navigation fires, incorrectly attributing its span with navigation.method: 'back'. Consider calling clearPendingExpoRouterNavigation() after a short timeout, or after confirming the navigation event fired.

Low

dismiss test omits `consumePendingExpoRouterNavigation` assertion present in the parallel `back` test - `packages/core/test/tracing/expoRouter.test.ts:424-444`

The dismiss test verifies the span and breadcrumb but never asserts that consumePendingExpoRouterNavigation() returns { method: 'dismiss' }, so a regression in setPendingExpoRouterNavigation for dismiss would go undetected.

⏱ 6m 17s · 1.1M in / 69.5k out · $2.36

Annotations

Check warning on line 176 in packages/core/src/js/tracing/expoRouter.ts

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

Stale `pendingExpoRouterNavigation` leaks to the next unrelated navigation span when `back()`/`dismiss()` is a no-op 

When `back()` is called on an empty navigation stack (or `dismiss()` with nothing to dismiss), `setPendingExpoRouterNavigation` stores a pending value but React Navigation never fires a navigation action, so `consumePendingExpoRouterNavigation` in `startIdleNavigationSpan` is never called — the stale entry persists until the *next* unrelated navigation fires, incorrectly attributing its span with `navigation.method: 'back'`. Consider calling `clearPendingExpoRouterNavigation()` after a short timeout, or after confirming the navigation event fired.
View more details on @sentry/warden