fix: llama-finetune backward pass crashes#21924
Open
System64fumo wants to merge 1 commit intoggml-org:masterfrom
Open
fix: llama-finetune backward pass crashes#21924System64fumo wants to merge 1 commit intoggml-org:masterfrom
System64fumo wants to merge 1 commit intoggml-org:masterfrom
Conversation
Fixes multiple crashes in llama-finetune that prevent training.
Contributor
|
Why are you making changes to the backend scheduler? |
Author
Because otherwise: Unless you're suggesting this be fixed elsewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes multiple crashes in llama-finetune that prevent training.
Closes: #18499 #21037
Additional information
Note: This doesn't fully fix/improve/change the behavior of the finetune tool, It only fixes the crashes.
@JohannesGaessler I propose adding a message to let users know there are deeper issues with the tool. (As stated in #18499)
The changes were tested against a simple dataset just to confirm the crashes were fixed and no further major crashes were left.
Proper finetune testing was not done as i don't have the time to let this run against a massive dataset to see actual results, But a simple test to confirm basic functionality with llama-server/llama-cli was done and worked just fine.
Requirements