cmake: remove CMP0194 policy to restore MSVC builds#21934
Open
texasich wants to merge 1 commit intoggml-org:masterfrom
Open
cmake: remove CMP0194 policy to restore MSVC builds#21934texasich wants to merge 1 commit intoggml-org:masterfrom
texasich wants to merge 1 commit intoggml-org:masterfrom
Conversation
github-actions
bot
added
the
ggml
Member
|
Ah, unfortunately not quite sufficient: |
texasich
force-pushed
the
fix/cmp0194-windows-msvc-regression
branch
from
4881bf5 to
47af609
Compare
Member
ggml-org#21630 added the CMP0194 NEW policy to silence a CMake warning, but on Windows runners it caused CMake to prefer the MinGW toolchain for ASM and broke MSVC builds. Reverting only that policy block restores the previous working behavior. The CMake 4.1+ warning comes back, but that is cosmetic and does not break any platform. Reported-by: oobabooga Refs: ggml-org#21630
texasich
force-pushed
the
fix/cmp0194-windows-msvc-regression
branch
from
47af609 to
cecf0c7
Compare
texasich
changed the title
texasich
changed the title
|
This PR want to fix the same problem as #21969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @oobabooga for catching this: #21630 (comment)
Overview
PR #21630 added CMP0194 NEW to silence a warning, but it broke Windows MSVC+Ninja.
Additional information
the first attempt at scoping ASM to kleidiai hit an unrelated CMake scoping issue on the ARM+KleidiAI self-hosted runner, so I pivoted to a minimal revert. This removes only the 6-line CMP0194 policy block from ggml/CMakeLists.txt. project("ggml" C CXX ASM) is left untouched, which is exactly the pre-#21630 state that was working on all platforms. The CMake 4.1+ warning returns but no platform breaks.
Requirements