Skip to content

fix: start tour when async steps load#1213

Open
wanxiankai wants to merge 1 commit into
gilbarbara:mainfrom
wanxiankai:fix/start-async-steps
Open

fix: start tour when async steps load#1213
wanxiankai wants to merge 1 commit into
gilbarbara:mainfrom
wanxiankai:fix/start-async-steps

Conversation

@wanxiankai

@wanxiankai wanxiankai commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • start the tour when run is already true and asynchronously loaded steps transition the store out of idle
  • use the normal controls.start() path so the store reaches running, emits tour:start, and respects stepIndex / initialStepIndex
  • add regression coverage for empty steps at mount followed by populated steps

Testing

  • pnpm test (479 tests)
  • pnpm typecheck
  • pnpm exec eslint src test e2e (0 errors)
  • pnpm build
  • pnpm size
  • pnpm typevalidation

Closes #1211

@codesandbox

codesandbox Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tour never starts when run is true from mount and steps are populated asynchronously

1 participant