fix: unwrap errors.Join() created joined errors in Context.Error()#4592
Open
larkwins wants to merge 2 commits intogin-gonic:masterfrom
Open
fix: unwrap errors.Join() created joined errors in Context.Error()#4592larkwins wants to merge 2 commits intogin-gonic:masterfrom
larkwins wants to merge 2 commits intogin-gonic:masterfrom
Conversation
added 2 commits
March 23, 2026 16:00
…in-gonic#4237) Automatically unwrap errors created by errors.Join() when passed to Context.Error(), so they are added as separate error entries instead of a single combined error. This improves error log readability and structure. Before: Error gin-gonic#1: gin error Error gin-gonic#2: service error store error Error gin-gonic#3: other error After: Error gin-gonic#1: gin error Error gin-gonic#2: service error Error gin-gonic#3: store error Error gin-gonic#4: other error Closes gin-gonic#4237
- Add '_ =' to ignore return values of c.Error() calls in tests - Add '_ =' to recursive c.Error() call in Context.Error() - Run gofmt to fix formatting issues
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4592 +/- ##
==========================================
- Coverage 99.21% 98.37% -0.84%
==========================================
Files 42 48 +6
Lines 3182 3146 -36
==========================================
- Hits 3157 3095 -62
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically unwrap errors created by errors.Join() when passed to
Context.Error(), so they are added as separate error entries instead
of a single combined error. This improves error log readability and
structure.
Before:
Error #1: gin error
Error #2: service error
store error
Error #3: other error
After:
Error #1: gin error
Error #2: service error
Error #3: store error
Error #4: other error
Closes #4237