Pp 2310 qr code unsupported warning flag by qnaveed87 · Pull Request #1180 · gini/gini-mobile-ios

qnaveed87 · 2026-06-19T16:31:10Z

Pull Request Description

This PR introduces a new remote configuration flag (unsupportedQRCodeWarningEnabled) to change how invalid QR codes are handled in the Capture camera flow, showing an “unsupported payment QR code” alert (with actions) when enabled.

Notes for Reviewers

Add unsupportedQRCodeWarningEnabled to ClientConfiguration (API + JSON test fixtures) and propagate it into GiniCaptureUserDefaultsStorage.
Update camera QR handling to optionally present an alert for unsupported QR codes and temporarily pause/resume QR detection.
Add new localized strings (EN/DE) for the alert title and actions.

… ClientConfiguration PP-2310

…ults storage PP-2310

… configuration PP-2310

…ameraProtocol PP-2310

…n in Camera PP-2310

…andlers to CameraViewController PP-2310

…eature flag in CameraViewController PP-2310

PP-2310

…ntConfiguration test fixture PP-2310

…e to ClientConfigurationTests PP-2310

Copilot

Pull request overview

This PR introduces a new remote configuration flag (unsupportedQRCodeWarningEnabled) to change how invalid QR codes are handled in the Capture camera flow, showing an “unsupported payment QR code” alert (with actions) when enabled.

Changes:

Add unsupportedQRCodeWarningEnabled to ClientConfiguration (API + JSON test fixtures) and propagate it into GiniCaptureUserDefaultsStorage.
Update camera QR handling to optionally present an alert for unsupported QR codes and temporarily pause/resume QR detection.
Add new localized strings (EN/DE) for the alert title and actions.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Resources/en.lproj/Localizable.strings	Adds EN localizations for the unsupported-QR alert UI.
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Resources/de.lproj/Localizable.strings	Adds DE localizations for the unsupported-QR alert UI.
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Storage/GiniCaptureUserDefaultsStorage.swift	Persists the new remote config flag into CaptureSDK user defaults storage.
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Camera/CameraPreviewViewController.swift	Exposes the camera instance so `CameraViewController` can pause/resume QR detection.
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Camera/Camera/CameraViewController.swift	Implements new invalid-QR behavior: snapshot flag once per session and show alert + pause/resume QR detection.
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Camera/Camera.swift	Adds QR detection pause/resume API and stores metadata output reference to enable toggling detection.
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift	Maps backend configuration into CaptureSDK defaults for the new flag.
BankAPILibrary/GiniBankAPILibrary/Tests/GiniBankAPILibraryTests/Resources/clientConfiguration.json	Extends JSON fixture with `unsupportedQRCodeWarningEnabled`.
BankAPILibrary/GiniBankAPILibrary/Tests/GiniBankAPILibraryTests/ClientConfigurationTests.swift	Extends tests to cover the new configuration property.
BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ClientConfiguration.swift	Adds the new configuration property and initializer parameter.

Comments suppressed due to low confidence (1)

BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Configuration/ClientConfiguration.swift:36

The initializer documentation comment doesn’t match the repository’s required Swift doc style for parameter lists (use - Parameters: and indent each parameter under it). Updating this block also keeps the new unsupportedQRCodeWarningEnabled entry consistent.

    /**
     Creates a new `ClientConfiguration` instance.

     - Parameters:
     - clientID: A unique identifier for the client.

PP-2310

…CodeWarningEnabled init param PP-2310

… CameraPreviewViewController PP-2310

…etection in Camera PP-2310

…iguration test helper PP-2310

…tupQRScanningOutput PP-2310

…y setter for pause/resume coverage PP-2310

…anningOutput PP-2310

zladzeyka

Thanks @qnaveed87, left a couple of suggestions.
Could please double check what will happen if the popup will be dismissed somehow bu the system, or use will put the app in the background? Will QR code detection be resumed?

zladzeyka · 2026-06-23T14:10:59Z

+                    hideQRCodeTask = DispatchWorkItem(block: {
+                        self.resetQRCodeScanning(isValid: false)
+                    })
+                    DispatchQueue.main.asyncAfter(deadline: .now() + 1.5, execute: hideQRCodeTask!)


[Suggestion]: Please handle force unwrap here

zladzeyka · 2026-06-23T14:29:27Z

        static let cameraTitle = NSLocalizedStringPreferredFormat("ginicapture.navigationbar.camera.title",
                                                                  comment: "Camera title")
+
+        static let unsupportedQRAlertTitleKey = "ginicapture.QRscanning.alert.title"


[Suggestion]: Wrapping all keys in the constants looks like overhead... was is need for lint?
We used before static let unsupportedQRAlertTitle = NSLocalizedStringPreferredFormat( "ginicapture.QRscanning.alert.title", comment: "Unsupported QR code alert title")

Yes. If we keep everything in a single line, SwiftLint raises a warning. We also follow the same pattern in PaymentDueHint

zladzeyka · 2026-06-23T14:54:20Z

    private var isValidIBANDetected: Bool = false
+    // Snapshot of the backend flag taken on the first invalid QR scan.
+    // Stays fixed for the session so all repeated scans show the same feedback type.
+    private var sessionUnsupportedQRCodeWarningEnabled: Bool?


[Suggestion]: Looks like one boolean should be enough like
private var sessionUnsupportedQRCodeWarningEnabled = false

Second bool is for manage the session to have 1 type of alert within same session.
Here is the AC fro the ticket

`Given the user already triggered an invalid QR-code warning earlier in the same SDK session, when the user scans a second (or subsequent) invalid QR-code, the SDK shows the same warning type as the first time.

This holds even if the configuration endpoint response resolves in between and changes the flag value (e.g. unsupportedQRCodeWarningEnabled becomes true).

Example: On first install, no ClientConfiguration is stored, so the default applies. The user scans an invalid QR-code before the endpoint responds and sees the old yellow warning. While they go back, the endpoint resolves with unsupportedQRCodeWarningEnabled = true. The user scans a second invalid QR-code and still sees the old yellow warning, not the new popup. The new popup only appears from the next SDK session onward.`

zladzeyka · 2026-06-23T14:56:58Z

+                // repeated scans in the same session. A separate boolean guards the snapshot
+                // because assigning nil to a Bool? still leaves it nil, making a nil-check
+                // unreliable as a "has snapshotted" gate.
+                if !isWarningFlagSnapshotted {


if we keep 1 boolean

Suggested change

if !isWarningFlagSnapshotted {

if !sessionUnsupportedQRCodeWarningEnabled {

sessionUnsupportedQRCodeWarningEnabled =

GiniCaptureUserDefaultsStorage.unsupportedQRCodeWarningEnabled == true

}

if sessionUnsupportedQRCodeWarningEnabled {

showUnsupportedQRCodeAlert()

} else {

Implemented as per the AC - 7

zladzeyka · 2026-06-23T15:22:04Z

    }

+    private func showUnsupportedQRCodeAlert() {
+        let generator = UINotificationFeedbackGenerator()


Suggested change

let generator = UINotificationFeedbackGenerator()

guard !isUnsupportedQRAlertPresented else { return }

isUnsupportedQRAlertPresented = true

let generator = UINotificationFeedbackGenerator()

Implemented as per the AC - 7

zladzeyka · 2026-06-23T15:23:21Z

        qrCodeOverLay.configureQrCodeOverlay(withCorrectQrCode: false)
    }

+    private func showUnsupportedQRCodeAlert() {


[Clarification]: pauseQRDetection() schedules its work asynchronously on sessionQueue, but the QR delegate fires per-frame and fans out via DispatchQueue.main.async for each frame. By the time the pause actually takes effect, several showUnsupportedQRCodeAlert() calls are already queued on the main thread-each one firing sendGiniAnalyticsEventForInvalidQRCode() and playVoiceOverMessage(). UIKit silently swallows the duplicate present() calls so there's no crash, but analytics and voice-over fire N times. Introducing `guard in suggestion below can be a fix.

I am not able to re produce issue with voice over but added guard so that it wont happen fro any edge case

…owQRCodeFeedback - Added Constants.hideQRCodeDelay PP-2310

…e-effects PP-2310

… metadata output PP-2310

sonarqubecloud · 2026-06-24T15:15:53Z

Quality Gate passed for 'iOS Bank SDK'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-06-24T15:23:04Z

Quality Gate passed for 'iOS Capture SDK'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-06-24T15:44:37Z

Quality Gate passed for 'iOS BankAPILibrary SDK'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

qnaveed87 added 14 commits June 17, 2026 09:30

feat(GiniBankAPILibrary): add unsupportedQRCodeWarningEnabled flag to…

6168241

… ClientConfiguration PP-2310

feat(GiniCaptureSDK): add unsupportedQRCodeWarningEnabled to UserDefa…

861f895

…ults storage PP-2310

feat(GiniBankSDK): passs unsupportedQRCodeWarningEnabled from backend…

fdda0a3

… configuration PP-2310

feat(GiniCaptureSDK): add pauseQRDetection and resumeQRDetection to C…

e34dc25

…ameraProtocol PP-2310

feat(GiniCaptureSDK): implement pauseQRDetection and resumeQRDetectio…

6c33e25

…n in Camera PP-2310

feat(GiniCaptureSDK): add unsupported QR code alert and user action h…

b4d8e16

…andlers to CameraViewController PP-2310

feat(GiniCaptureSDK): gate unsupported QR code alert behind backend f…

bceb1de

…eature flag in CameraViewController PP-2310

feat(GiniCaptureSDK): Update access modifier fro camera protocol

2970d07

PP-2310

feat(BankSDK): Code indentation

f8f360a

PP-2310

fix(GiniCaptureSDK): snapshot unsupported QR code flag once per session

aa4f9f6

PP-2310

fix(GiniBankSDK): Added localized strings

754b5b5

PP-2310

feat(GiniBankSDK): Update strings via localized string

4fdb092

PP-2310

feat(GiniBankAPILibrary): add unsupportedQRCodeWarningEnabled to clie…

1fe374b

…ntConfiguration test fixture PP-2310

test(GiniBankAPILibrary): add unsupportedQRCodeWarningEnabled coverag…

9295a09

…e to ClientConfigurationTests PP-2310

qnaveed87 requested a review from Copilot June 19, 2026 16:31

qnaveed87 had a problem deploying to firebase-manual-deploy June 19, 2026 16:31 — with GitHub Actions Error

Copilot started reviewing on behalf of qnaveed87 June 19, 2026 16:31 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

qnaveed87 self-assigned this Jun 22, 2026

qnaveed87 added 2 commits June 22, 2026 17:11

fix(GiniBankSDK): Fix CameraMock conformance to CameraProtocol

25249e1

PP-2310

fix(GiniCaptureSDK): Fix CameraMock conformance to CameraProtocol

8f2d97f

PP-2310

qnaveed87 had a problem deploying to firebase-manual-deploy June 22, 2026 15:21 — with GitHub Actions Error

qnaveed87 added 3 commits June 22, 2026 17:30

refactor(GiniBankAPILibrary): remove default value from unsupportedQR…

bc2f62c

…CodeWarningEnabled init param PP-2310

refactor(GiniCaptureSDK): restrict camera property to private(set) in…

d39e992

… CameraPreviewViewController PP-2310

test(GiniCaptureSDK): add coverage for pauseQRDetection and resumeQRD…

bebc167

…etection in Camera PP-2310

qnaveed87 had a problem deploying to firebase-manual-deploy June 22, 2026 16:43 — with GitHub Actions Error

test(GiniBankSDK): pass unsupportedQRCodeWarningEnabled to ClientConf…

156de27

…iguration test helper PP-2310

qnaveed87 had a problem deploying to firebase-manual-deploy June 22, 2026 16:54 — with GitHub Actions Error

test(GiniCaptureSDK): remove flaky QR detection tests that rely on se…

46a171e

…tupQRScanningOutput PP-2310

qnaveed87 had a problem deploying to firebase-manual-deploy June 22, 2026 18:13 — with GitHub Actions Error

test(GiniCaptureSDK): add private(set) qrMetadataOutput with test-onl…

cf9f57e

…y setter for pause/resume coverage PP-2310

qnaveed87 marked this pull request as ready for review June 23, 2026 06:41

qnaveed87 had a problem deploying to firebase-manual-deploy June 23, 2026 06:41 — with GitHub Actions Error

test(GiniCaptureSDK): cover qrMetadataOutput assignment via setupQRSc…

17f68bc

…anningOutput PP-2310

qnaveed87 had a problem deploying to firebase-manual-deploy June 23, 2026 10:16 — with GitHub Actions Error

qnaveed87 changed the base branch from main to release/qr-code-improvements June 23, 2026 12:56

qnaveed87 requested review from ValentinaIancu-Gini, lestergini and zladzeyka June 23, 2026 12:58

zladzeyka requested changes Jun 23, 2026

View reviewed changes

qnaveed87 added 3 commits June 24, 2026 14:34

refactor(GiniCaptureSDK): remove force unwrap of hideQRCodeTask in sh…

5f41f49

…owQRCodeFeedback - Added Constants.hideQRCodeDelay PP-2310

fix(GiniCaptureSDK): guard against duplicate unsupported QR alert sid…

fa65534

…e-effects PP-2310

test(GiniCaptureSDK): cover [.qr] assignment in resumeQRDetection via…

996b596

… metadata output PP-2310

qnaveed87 requested a deployment to firebase-manual-deploy June 24, 2026 14:52 — with GitHub Actions Waiting

qnaveed87 requested a review from zladzeyka June 24, 2026 15:26

-                if !isWarningFlagSnapshotted {
+ if !sessionUnsupportedQRCodeWarningEnabled {
+     sessionUnsupportedQRCodeWarningEnabled =
+         GiniCaptureUserDefaultsStorage.unsupportedQRCodeWarningEnabled == true
+ }
+ if sessionUnsupportedQRCodeWarningEnabled {
+     showUnsupportedQRCodeAlert()
+ } else {

Conversation

qnaveed87 commented Jun 19, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Notes for Reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zladzeyka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 24, 2026

Quality Gate passed for 'iOS Bank SDK'

Uh oh!

sonarqubecloud Bot commented Jun 24, 2026

Quality Gate passed for 'iOS Capture SDK'

Uh oh!

sonarqubecloud Bot commented Jun 24, 2026

Quality Gate passed for 'iOS BankAPILibrary SDK'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qnaveed87 commented Jun 19, 2026 •

edited by atlassian Bot

Loading