Open
Conversation
Frostman
requested review from
Copilot and
qmonnet
and removed request for
a team
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI dev.yml workflow to gate “release tests” behind a PR label and (when enabled via that label) narrow the release test selection to gateway-related tests.
Changes:
- Document a new PR label (
ci:+release) for enabling release tests on PRs. - Pass a new
releasetest_regexinput to the reusablerun-vlab.yamlworkflow to filter release tests to “Gateway” when the label is present.
Frostman
force-pushed
the
dev/frostman/rt
branch
2 times, most recently
from
65a5620 to
8ff810a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the CI vlab job invocation so that “release tests” can be scoped to gateway-related tests only, reducing the breadth of release testing when explicitly enabled.
Changes:
- Document
ci:+releaseas enabling release tests on PRs (gateway-related only). - Pass a new
releasetest_regexinput (set toGatewaywhen release tests are enabled) to the reusablerun-vlab.yamlworkflow.
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Frostman
force-pushed
the
dev/frostman/rt
branch
from
8ff810a to
331d2a2
Compare
mvachhar
approved these changes
Apr 15, 2026
Frostman
added
dont-merge
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow to scope “release tests” to only gateway-related cases when release tests are enabled (via label or workflow_dispatch input), reducing the release-test surface area in VLAB/HLAB runs.
Changes:
- Appends an
-rtgsuffix to the VLAB job name when release tests are enabled. - Documents
ci:+releasebehavior and how it affects HLAB/VLAB runs. - Adds
releasetest_regexto only run gateway-related release tests when release tests are enabled.
| - check_changes | ||
|
|
||
| name: "${{ matrix.hybrid && 'h' || 'v' }}-${{ matrix.upgradefrom && 'up' || '' }}${{ matrix.upgradefrom }}${{ matrix.upgradefrom && '-' || '' }}${{ matrix.mesh && 'mesh-' || '' }}${{ matrix.gateway && 'gw-' || '' }}${{ matrix.includeonie && 'onie-' || '' }}${{ matrix.buildmode }}-${{ matrix.vpcmode }}" | ||
| name: "${{ matrix.hybrid && 'h' || 'v' }}-${{ matrix.upgradefrom && 'up' || '' }}${{ matrix.upgradefrom }}${{ matrix.upgradefrom && '-' || '' }}${{ matrix.mesh && 'mesh-' || '' }}${{ matrix.gateway && 'gw-' || '' }}${{ matrix.includeonie && 'onie-' || '' }}${{ matrix.buildmode }}-${{ matrix.vpcmode }}${{ (inputs.enable_release_test == true || contains(github.event.pull_request.labels.*.name, 'ci:+release')) && '-rtg' || '' }}" |
| # ci:-upgrade disables upgrade tests on PR | ||
| # hlab is disabled for main and merge_queue till we have gateway tests for it | ||
| # ci:+release enables release tests on PR (only tests related to the gateway) | ||
| # hlab if it's enabled together with the release tests, it'll now run only gateway tests |
Frostman
added
dont-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.