[log] Add debug logging to unified server key functions#5031
Merged
Conversation
Add meaningful debug logging to three functions in internal/server/unified.go that previously had no logging: - executeBackendToolCall: log entry with serverID/toolName and backend errors - getCircuitBreaker: log when creating a new circuit breaker on-demand - GetToolHandler: log when no handler is found for a requested tool Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional debug-level observability in the unified MCP server to make backend tool dispatch, circuit-breaker initialization, and routed tool lookups easier to trace during troubleshooting.
Changes:
- Log entry + backend error code in
executeBackendToolCallto correlate tool dispatch with backend failures. - Log when
getCircuitBreakercreates a breaker on-demand (outside the normalNewUnifiedinitialization path). - Log when
GetToolHandlercan’t find a handler for a requestedbackendID/toolNamepair.
Show a summary per file
| File | Description |
|---|---|
internal/server/unified.go |
Adds debug logging to key unified-server functions for improved tracing and diagnosis. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds meaningful debug logging to three functions in
internal/server/unified.gothat previously had no logging:Changes
executeBackendToolCall: Logs entry withserverIDandtoolNamefor tracing tool dispatch, and logs when the backend returns an error (with error code) to help correlate backend failures.getCircuitBreaker: Logs when a new circuit breaker is created on-demand (i.e., outside of the normalNewUnifiedpath), including the configured threshold and cooldown values.GetToolHandler: Logs when no handler is found for the requestedbackendID/toolNamecombination, which helps diagnose tool routing issues in routed mode.Testing
go buildpassesgo test ./...passes (pre-existing unrelated failure inTestFetchAndFixSchema_NetworkErrorininternal/config)internal/server/unified.gowas modifiedWarning
The following domain was blocked by the firewall during workflow execution:
invalidhostthatdoesnotexist12345.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.