Conversation
Add missing test workflow and Go compiler test for the report-incomplete safe output type, which signals that a task could not be completed due to an infrastructure or tool failure. - pkg/cli/workflows/test-copilot-report-incomplete.md: new test workflow - pkg/workflow/compiler_safe_outputs_config_test.go: new test case Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe Output Test Coverage
This PR adds test workflows and Go compiler tests for the
report-incompletesafe output type, which was the only type lacking test coverage.New Test Workflows Added
pkg/cli/workflows/test-copilot-report-incomplete.md— exercises thereport-incompletesafe output type with the Copilot engine; asks the agent to signal task incompletion due to a simulated infrastructure failureGo Tests Added
Added
"report_incomplete config"test case toTestAddHandlerManagerConfigEnvVarinpkg/workflow/compiler_safe_outputs_config_test.go. The test verifies thatReportIncompleteConfigis correctly serialized into theGH_AW_SAFE_OUTPUTS_HANDLER_CONFIGenvironment variable with the expectedreport_incompletekey.Summary
All 39 safe-output types now have test coverage. The previously uncovered type was:
report-incompletetest-copilot-report-incomplete.mdreport_incomplete configReferences: §24055463181