Skip to content

Convert test infrastructure from Karma/Mocha/Chai to Vitest with Playwright #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgreif merged 5 commits into from
Oct 13, 2025
Merged

Convert test infrastructure from Karma/Mocha/Chai to Vitest with Playwright #68

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2cb7c8a
Initial plan
Copilot Oct 10, 2025
13f0143
Convert from Karma/Mocha/Chai to Vitest with Playwright
Copilot Oct 10, 2025
2c134b3
Remove test/.eslintrc.json with mocha reference
Copilot Oct 10, 2025
1e00d9f
Address PR feedback: revert to node-version-file, move eslint config,…
Copilot Oct 10, 2025
f2a8509
Add build and lint steps to publish workflow
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.node-version'
node-version: 24
Copy link
Copy Markdown
Contributor

@dgreif dgreif Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot revert to using node-version-file in the CI workflows. Then update .node-version contents to 24

Copy link
Copy Markdown
Contributor Author

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit above. Both workflows now use node-version-file: '.node-version' and .node-version contains 24.

cache: 'npm'
- run: npm install
- run: npx playwright install chromium --only-shell
- run: npm run build
- run: npm run lint
- run: npm test
env:
CI: true
3 changes: 2 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.node-version'
node-version: 24
registry-url: https://registry.npmjs.org/
cache: npm
- run: npm ci
- run: npx playwright install chromium --only-shell
- run: npm test
Comment thread
dgreif marked this conversation as resolved.
- run: npm version ${TAG_NAME} --git-tag-version=false
env:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
dist/
node_modules/
test/__screenshots__/
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22
24
25 changes: 0 additions & 25 deletions karma.config.js
View file
Open in desktop

This file was deleted.

Loading