Skip to content

Update to new jzarr 0.4.2 - #110

Merged
sbesson merged 5 commits into
glencoesoftware:masterfrom
melissalinkert:jzarr-switch
Nov 16, 2023
Merged

Update to new jzarr 0.4.2#110
sbesson merged 5 commits into
glencoesoftware:masterfrom
melissalinkert:jzarr-switch

Conversation

@melissalinkert

Copy link
Copy Markdown
Member

@melissalinkert

Copy link
Copy Markdown
Member Author

I think the build failure is expected until glencoesoftware/bioformats2raw#203 is released and the bioformats2raw version is updated here.

@sbesson

sbesson commented Sep 22, 2023

Copy link
Copy Markdown
Member

I think the build failure is expected until glencoesoftware/bioformats2raw#203 is released and the bioformats2raw version is updated here.

Agreed, although the fact that the GitHub workflow builds did not fail is a slight concern as it's performing the same build.
Could you try removing

to see if it's a side-effect of the caching?

@melissalinkert melissalinkert changed the title Update to new jzarr 0.4.0 Update to new jzarr 0.4.2 Nov 6, 2023

@sbesson sbesson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit consuming the 0.8.0-rc1 release candidate of bioformat2raw fixes the GitHub Actions build and also updates the usage of the listener API to match the backwards-incompatible changes introduced in glencoesoftware/bioformats2raw#221.

Tested functionally on a handful of samples of different modalities (WSI, multi-dimensional fluorescence). Let's get this merged to align the low-level Zarr library used across these converted utilities

@sbesson
sbesson merged commit 51d15e2 into glencoesoftware:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants