-
Notifications
You must be signed in to change notification settings - Fork 18
feat(input-dropdown): add inline search functionality #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brc-dd
wants to merge
18
commits into
main
Choose a base branch
from
feat/inline-search-dropdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
84f144f
feat(input-dropdown): add inline search functionality
brc-dd 8816515
Update lib/components/SDropdownSectionFilter.vue
brc-dd af2bd50
Add type="button" to inline chip close buttons (#663)
Copilot c4ce2ea
Update lib/composables/Dropdown.ts
brc-dd acdeae5
Add ARIA attributes for inline search combobox accessibility (#664)
Copilot bcdac88
rename
brc-dd 3d1021a
fix redundant code
brc-dd 5f50045
Update lib/components/SDropdownSectionFilter.vue
brc-dd 1b97545
adjust
brc-dd f9de731
fix naming
brc-dd 2bed66f
Add internationalized aria-labels to inline chip close buttons (#665)
Copilot 18510fc
Eliminate chip rendering duplication in SInputDropdown inline search …
Copilot 4d9ad33
Add Escape key handling for inline search in SInputDropdown (#669)
Copilot b321e88
Add insertOnSpace prop to control Space key selection in inline searc…
Copilot a46743e
adjust
brc-dd 9fb0d9e
Add test coverage for inline search functionality in SInputDropdown (…
Copilot 8aa0cba
adjust threshold and tests
brc-dd ca490bd
revert
brc-dd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.