Skip to content

Add type="button" to inline chip close buttons#663

Merged
brc-dd merged 2 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661
Dec 8, 2025
Merged

Add type="button" to inline chip close buttons#663
brc-dd merged 2 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 8, 2025

Close buttons in inline chip rendering defaulted to type="submit", causing unintended form submissions when used within forms.

Changes:

  • Added type="button" attribute to close buttons in both multi-select and single-select inline chip rendering
<button
  v-if="removable"
  type="button"
  class="inline-chip-close"
  :disabled="disabled ?? false"
  @click.stop="handleSelect(item.value)"
>
  <IconX class="inline-chip-close-icon" />
</button>

Addresses feedback from #661.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix feedback on inline search functionality in input-dropdown PR Add type="button" to inline chip close buttons Dec 8, 2025
Copilot AI requested a review from brc-dd December 8, 2025 01:23
@brc-dd brc-dd marked this pull request as ready for review December 8, 2025 01:24
@brc-dd brc-dd requested a review from kiaking as a code owner December 8, 2025 01:24
@brc-dd brc-dd merged commit af2bd50 into feat/inline-search-dropdown Dec 8, 2025
1 check passed
@brc-dd brc-dd deleted the copilot/sub-pr-661 branch December 8, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants