Skip to content

Add ARIA attributes for inline search combobox accessibility#664

Merged
brc-dd merged 6 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661
Dec 8, 2025
Merged

Add ARIA attributes for inline search combobox accessibility#664
brc-dd merged 6 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 8, 2025

  • Add required ARIA attributes to combobox implementation
    • Import and use Vue's useId() to generate unique IDs
    • Add aria-expanded attribute to indicate dropdown state
    • Add aria-controls attribute to reference the dropdown listbox
    • Add aria-activedescendant to indicate currently active option
    • Add id to the dropdown element
    • Add role="listbox" to the dropdown for proper semantics
    • Add role="option" and aria-selected to each option
  • Test the changes to ensure ARIA attributes work correctly
  • Code review completed
  • Revert .gitignore changes and apply linter fixes

Summary

All ARIA accessibility attributes have been successfully implemented for the inline search combobox mode. The changes improve screen reader support and follow ARIA best practices for combobox widgets.

Changes in this commit

  • Reverted .gitignore to remove package-lock.json entry
  • Applied linter fixes (import ordering and attribute ordering)

Security Summary

✅ No security vulnerabilities detected by CodeQL analysis.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Dec 8, 2025
Copilot AI and others added 3 commits December 8, 2025 01:34
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Copilot AI changed the title [WIP] Update inline search functionality based on feedback Add ARIA attributes for inline search combobox accessibility Dec 8, 2025
Copilot AI requested a review from brc-dd December 8, 2025 01:39
@brc-dd
Copy link
Copy Markdown
Member

brc-dd commented Dec 8, 2025

@copilot remove package-lock.json, use pnpm (npm install -g pnpm@latest-10), revert .gitignore, run pnpm run lint and commit

Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Dec 8, 2025

@copilot remove package-lock.json, use pnpm (npm install -g pnpm@latest-10), revert .gitignore, run pnpm run lint and commit

Done in commit f61d986:

  • Reverted .gitignore (removed package-lock.json entry)
  • Installed pnpm@10.23.0 globally
  • Ran pnpm run lint successfully
  • Applied linter fixes (import and attribute ordering)

@brc-dd brc-dd marked this pull request as ready for review December 8, 2025 01:55
@brc-dd brc-dd requested a review from kiaking as a code owner December 8, 2025 01:55
@brc-dd brc-dd merged commit acdeae5 into feat/inline-search-dropdown Dec 8, 2025
1 check passed
@brc-dd brc-dd deleted the copilot/sub-pr-661 branch December 8, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants