Skip to content

Add insertOnSpace prop to control Space key selection in inline search#668

Merged
brc-dd merged 3 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661-again
Dec 8, 2025
Merged

Add insertOnSpace prop to control Space key selection in inline search#668
brc-dd merged 3 commits into
feat/inline-search-dropdownfrom
copilot/sub-pr-661-again

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 8, 2025

Addresses feedback from PR #661 where Space key unconditionally triggers selection, preventing users from typing spaces in search queries (e.g., "Vue.js Framework").

Changes

  • New prop insertOnSpace?: boolean - Controls Space key behavior in inline search mode. Defaults to true for backward compatibility.
  • Conditional Space handling - Space only triggers selection when insertOnSpace={true}. When false, users can type spaces normally.
  • Refactored selection logic - Extracted duplicate Enter/Tab/Space handling into handleInlineSelect() helper.

Usage

<!-- Default: Space selects active option -->
<SInputDropdown search="inline" :options="options" v-model="value" />

<!-- Allow typing spaces in search -->
<SInputDropdown 
  search="inline" 
  :insert-on-space="false"
  :options="options" 
  v-model="value" 
/>

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 8, 2025 02:44
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: brc-dd <40380293+brc-dd@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on inline search functionality Add insertOnSpace prop to control Space key selection in inline search Dec 8, 2025
Copilot AI requested a review from brc-dd December 8, 2025 02:48
@brc-dd brc-dd marked this pull request as ready for review December 8, 2025 02:56
@brc-dd brc-dd requested a review from kiaking as a code owner December 8, 2025 02:56
@brc-dd brc-dd merged commit b321e88 into feat/inline-search-dropdown Dec 8, 2025
1 check passed
@brc-dd brc-dd deleted the copilot/sub-pr-661-again branch December 8, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants