fix(gnovm): avoid panic on assertion over nil slice #5780
+19
−2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| gno run . | ||
|
|
||
| -- main.gno -- | ||
| // Copyright 2022 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. | ||
|
|
||
| // Test case where a slice of a user-defined byte type (not uint8 or byte) is | ||
| // converted to a string. Same for slice of runes. | ||
|
|
||
| package main | ||
|
|
||
| type MyByte byte | ||
|
|
||
| type MyRune rune | ||
|
|
||
| func main() { | ||
| var y []MyByte | ||
| _ = string(y) | ||
|
|
||
| var z []MyRune | ||
| _ = string(z) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -787,8 +787,10 @@ func (m *Machine) doOpConvert() { | |
| } else if t.Kind() == StringKind { | ||
| // runes ([]int32) → string | ||
| if st, ok := baseOf(xv.T).(*SliceType); ok && st.Elt.Kind() == Int32Kind { | ||
| if xv.V != nil { | ||
| sv := xv.V.(*SliceValue) | ||
| m.incrCPU(OpCPUSlopeConvertRunesStr * int64(sv.GetLength())) | ||
| } | ||
|
Contributor
Author
There was a problem hiding this comment. Maybe a philosophical question but should we increment the CPU for converting an empty string (0 length) ?
Member
There was a problem hiding this comment. Suggestion: m.incrCPU(OpCPUSlopeConvertRunesStr * int64(xv.GetLength()))This also mirrors the string→runes branch above, which is nil-safe for the same reason (
Contributor
Author
There was a problem hiding this comment. Done here thanks for the review: 8bec3e7 |
||
| } | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit on placement: this txtar runs
gno run .but lives intestdata/test/, where every other script exercises thegno testsubcommand (the testdata subdirs are grouped per subcommand). Since this is a VM-behavior regression rather than a CLI one, the canonical home would be a filetest ingnovm/tests/files/with an// Output:comment — lighter weight (runs underTestFilesinstead of spinning up the CLI), and the issue body is already written in that format, so it converts directly.Optional while you're at it: only the
[]MyRuneline actually reaches the buggy branch ([]MyBytenever enters theInt32Kindgas path). Adding a plainvar r []rune; _ = string(r)would document that the bug wasn't specific to declared types.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed here 8bec3e7
For the change on the type I could do it but this file references Golang tests so I don't know if a good idea to modify it let me know if you still want to do the change and I'll do it