chore(boards2): Make public API non-crossing again, move to main folder#5809
Open
jefft0 wants to merge 8 commits into
Open
chore(boards2): Make public API non-crossing again, move to main folder#5809jefft0 wants to merge 8 commits into
jefft0 wants to merge 8 commits into
Conversation
…dsNS and realm param Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…boards/exts/hub Signed-off-by: Jeff Thompson <jeff@thefirst.org>
… parent folder Signed-off-by: Jeff Thompson <jeff@thefirst.org>
…der. Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Collaborator
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boards2/v1/hubhas simplified structs and API queries for read-only access to boards2 data. But the interrealm changes in #5669 required addingcur realmto all the hub functions in order to authorize the calling realm. This made them crossing functions and not suitable for a query API. Therefore, we must give up the "hub" abstraction.In general, this PR moves the simplified structs to
p/gnoland/boards/exts/huband the public API inhub.gnoto the main folder.Board,ThreadandComment(and related tests) top/gnoland/boards/exts/hub. Also move the local helperformat.gnoto therehub.gnoto the main folder. AccessgBoardsdirectly instead ofGetBoard, etc. inprotected.gno. Rename it's helpergetThreadtogetBoardThread, and have it call the originalgetThreaddirectlyprotected.gno. This includesGetRealmPermissionsandGetBoardwhich check permissions (no longer supported). So remove the related filetestsboards2/v1/hub/filetestsfromz_*.gnotoz_hub_*.gno. Move them toboards2/v1/filetestsTODO: Check if should remove
ref *boards.Boardfrom the Board struct, etc.TODO: Confirm the updated header comment in
hub.gno.