fix(gnovm): recover panics when having unhashable type as map key#5821
Open
Villaquiranm wants to merge 1 commit into
Open
fix(gnovm): recover panics when having unhashable type as map key#5821Villaquiranm wants to merge 1 commit into
Villaquiranm wants to merge 1 commit into
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
davd-gzl
reviewed
Jun 12, 2026
| } | ||
| // Statically uncomparable key types are rejected at preprocess, so any | ||
| // uncomparable tv.T here arrived via interface boxing. Match Go by | ||
| // naming the outer dynamic type — isComparable recurses, so a struct |
Member
There was a problem hiding this comment.
This comment can be simplified
davd-gzl
approved these changes
Jun 12, 2026
Member
There was a problem hiding this comment.
Looks good. Verified on dc9e0ac: the panic message matches Go for every key shape, and equality and lookup still work for comparable interface-boxed keys.
- Optional: the new filetests only cover the failure path; a small positive-case filetest (a comparable key boxed into
map[interface{}]V) would guard the happy path too.
(AI Agent)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5783