This repository was archived by the owner on Aug 24, 2021. It is now read-only.
in replaceOwner, newOwner must be not null! and ...#214
Open
sebkim wants to merge 1 commit intognosis:masterfrom
Open
in replaceOwner, newOwner must be not null! and ...#214sebkim wants to merge 1 commit intognosis:masterfrom
sebkim wants to merge 1 commit intognosis:masterfrom
Conversation
Contributor
|
Well actually this should be possible, Imagine you participate in a DAO with a multisig and no longer want to have ownership of this multisig, to probe you don't hold rights over this account. With an EOA this is not possible |
Contributor
|
the 0 address is practically not possible to have, I mean it could save errors, true, and if you want to have a non practical address we could use 0x1. But, this is a multisig tx, why always pay more for a check? owners will need to approve it anyways and for that validate what they are signing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
additionally, the fallback function should explicitly declare public visibility.