Fix random numbers#689
Closed
jsallay wants to merge 2 commits intognuradio:mainfrom
Closed
Conversation
The range of random numbers for integer tests is not correct. For uint64_t it was overflowing and only producing 0's and 1's. Signed-off-by: John Sallay <jasallay@gmail.com>
Signed-off-by: John Sallay <jasallay@gmail.com>
Member
|
I already have a pull request open to fix this (and some other bugs in random integer generation): #677 |
Member
|
#677 does include all the improvements made here, but one small difference is that it keeps the |
Contributor
Author
|
I don't have a problem with closing this.
…On Sat, Nov 4, 2023, 7:07 AM Clayton Smith ***@***.***> wrote:
#677 <#677> does include all the
improvements made here, but one small difference is that it keeps the
int16_t range at -7 .. +7 (for now) since some tests would become flaky
if it was increased to the full numeric range of int16_t.
—
Reply to this email directly, view it on GitHub
<#689 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPWDXFX2DTB7C6FTDW4LNLYCYOWLAVCNFSM6AAAAAA6UBCNACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGQYTGNJVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
Alright, I'm closing this PR in favor of #677 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #688
Note that we need to merge #606 beforehand because the armv8 unit test fails if we fix the random numbers.