Skip to content

FIlter failed kernels #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viktor3308 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIlter failed kernels #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/qa_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,8 @@ bool run_volk_tests(volk_func_desc_t desc,
}
}
}
arch_results.push_back(!fail);
volk_test_time_t* result = &results->back().results[arch_list[i]];
arch_results.push_back(result->pass);
Comment on lines -1386 to +1387
Copy link
Copy Markdown
Contributor

@jdemel jdemel Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still inside the loop for one architecture. I don't see how this would fail.
But: I'd argue the actual problem in this loop is the complexity. It would make more sense to refactor it and create a simpler problem.

}

double best_time_a = std::numeric_limits<double>::max();
Expand Down