libs-gui: only create icon/miniwindow when GSSuppressAppIcon is explicitly NO

[probonopd]

As discussed in the last monthly meeting, creating miniwindows should only happen when requested (opt-in).

Previously, the app icon and miniwindow were created unconditionally and only the display was suppressed. This led to unnecessary allocations and potential issues when GSSuppressAppIcon was not set.

With this change, _appIconInit returns early if GSSuppressAppIcon is not set to NO, and miniwindow creation is skipped unless GSSuppressAppIcon is NO. Also adds a nil check before GSRemoveIcon to prevent potential crashes.

This change is based on gershwin-desktop/gershwin-developer@e8f2110

cc @gcasa @pkgdemon

[probonopd]

I suspect the test failures are not caused by this PR (which doesn't touch fonts), what do you think?

gui/NSFont/named.m:
Failed file:  named.m aborted without running all tests!
Failed test:     (2026-08-31 14:26:57.787 UTC)   named.m:37 ... fontWithName:size: returns a font
Failed test:     (2026-08-31 14:26:57.787 UTC)   named.m:39 ... the font keeps the requested name
Failed test:     (2026-08-31 14:26:57.787 UTC)   named.m:40 ... the font has the requested point size

[gcasa]

I suspect the test failures are not caused by this PR (which doesn't touch fonts), what do you think?

gui/NSFont/named.m:
Failed file:  named.m aborted without running all tests!
Failed test:     (2026-08-31 14:26:57.787 UTC)   named.m:37 ... fontWithName:size: returns a font
Failed test:     (2026-08-31 14:26:57.787 UTC)   named.m:39 ... the font keeps the requested name
Failed test:     (2026-08-31 14:26:57.787 UTC)   named.m:40 ... the font has the requested point size

I just re-ran this. It fails in the same way. I am not sure what could have changed to cause this issue.

[gcasa]

The failure in named.m is because there doesn't always have to be a "Helvetica" font. In the art backend, this was a safe assumption since it copied in a "Helvetica.nfont" (nfonts are something created by Deek / Jeff Teuneissen) to fulfill this. I am not sure why we didn't see this failure until now, but it's my guess that that is the cause here.

[gcasa]

Please try this version of named.m... I have zipped it here. It retrieves the names of all fonts and then grabs one by name. This ensures were are using a font that is actually installed.

named.m.zip

[probonopd]

Thanks @gcasa.
Wouldn't you want to get that applied independently from my PR, and then rebase my PR on top of it?

[gcasa]

Thanks @gcasa. Wouldn't you want to get that applied independently from my PR, and then rebase my PR on top of it?

I had thought about that. I will try it.

[fredkiefer]

Not sure whether that change will help. What should happen with the name "Helvetica" is that it is hard coded into NSFont and if no font with that name can be found, we try the default font, whatever the backend uses for that. What could be happening there is that none of the well known fonts is present.
And as you correctly asked, why is this happening now and didn't happen for the last merged PR? One possible option is that a new base image is being used.

I'll have a look at what the frame buffer version of cairo is using here, but I would expect it to have all the normal fontconfig fonts.

[gcasa]

I have pushed this change on master. Please pull that change.

[gcasa]

FYI, I have been frustrated with the current behavior. In my view, GSSuppressAppIcon should act as you suggest.

[gcasa]

Not sure whether that change will help. What should happen with the name "Helvetica" is that it is hard coded into NSFont and if no font with that name can be found, we try the default font, whatever the backend uses for that. What could be happening there is that none of the well known fonts is present. And as you correctly asked, why is this happening now and didn't happen for the last merged PR? One possible option is that a new base image is being used.

I'll have a look at what the frame buffer version of cairo is using here, but I would expect it to have all the normal fontconfig fonts.

My approach here was to avoid the hardcoding and find all fonts and get the name of the first one. This way it preserves the intention of the test. I think you're saying we should hardcode "Helvetica" so that referencing that (if Helvetica itself isn't available) it will get the default font. Is that correct?

[gcasa]

So now the font tests are failing in a different place?

[pkgdemon]

So now the font tests are failing in a different place?

From the test log:

Testing convert.m...
Running gui/NSFontManager/convert.m...
Start set:       convert.m:22 ... convertFont:toSize:
2026-09-02 17:42:19.885 convert[28134:28134] Failed to get _NET_WORKAREA
2026-09-02 17:42:19.894 convert[28134:28134] Failed to get _NET_WORKAREA
Failed test:     (2026-09-02 17:42:19.904 UTC)   convert.m:40 ... the converted font has the requested size
Failed test:     (2026-09-02 17:42:19.904 UTC)   convert.m:42 ... the converted font keeps the original name
Passed test:     (2026-09-02 17:42:19.904 UTC)   convert.m:44 ... converting to the current size returns the original font
End set:         convert.m:50 ... convertFont:toSize:

[probonopd]

Looks like the Cairo backend needs a window for the screen to be initialized, which is used for font size conversions. Since we no longer have the miniicon windows, we probably need to initialize the display connection manually in the test.

Does this sound correct @gcasa?

[gcasa]

Looks like the Cairo backend needs a window for the screen to be initialized, which is used for font size conversions. Since we no longer have the miniicon windows, we probably need to initialize the display connection manually in the test.

Does this sound correct @gcasa?

I don't think so. From my experience... (granted I have limited experience with the backend, thankfully it is very stable)... initializeContext for CairoContext currently only registers the default graphics context and font classes. It doesn't create or inspect a window. It just creates the display server. What leads you to the conclusion that a window is needed?