Skip to content

debos: disable ext4 dir_index on scratch for 32-bit architectures #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
obbardc wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

debos: disable ext4 dir_index on scratch for 32-bit architectures #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/debos/debos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,14 @@ func doRun(r actions.Recipe, context *debos.Context) bool {
return true
}

func is32BitArch(arch string) bool {
switch arch {
case "armhf", "armel", "i386", "mips", "mipsel", "powerpc", "sh4":
return true
}
return false
}

func warnLocalhost(variable string, value string) {
message := `WARNING: Environment variable %[1]s contains a reference to
localhost. This may not work when running from fakemachine.
Expand Down Expand Up @@ -340,6 +348,11 @@ func main() {
log.Printf("WARNING: Scratch size of %dMB is less than recommended minimum 512MB\n", scratchsizeMB)
}
m.SetScratch(size, "")
if is32BitArch(r.Architecture) {
// dir_index stores d_off as a hash which can exceed INT32_MAX,
// causing readdir() to return EOVERFLOW on 32-bit guests.
m.SetScratchMkfsArgs([]string{"-O", "^dir_index"})
}
}

m.SetShowBoot(options.ShowBoot)
Expand Down
Loading