embed: return fs.ErrInvalid for invalid Seek whence by TheRodzz · Pull Request #80725 · golang/go

TheRodzz · 2026-08-05T04:18:27Z

google-cla · 2026-08-05T04:18:32Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2026-08-05T04:48:03Z

This PR (HEAD: 12024b0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/810660.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

This commit addresses an inconsistency in the behavior of the Seek method implemented by embed.FS compared to os.File. Previously, when an invalid whence value was provided to Seek on an embedded file, the method would silently ignore the error and perform no operation. To align the behavior with the standard io.Seeker interface and os.File, we now explicitly validate the whence parameter. If the provided whence is not one of io.SeekStart, io.SeekCurrent, or io.SeekEnd, the method will return an fs.ErrInvalid error. A regression test has also been added to ensure this behavior remains correct. Fixes golang#80696

gopherbot · 2026-08-05T05:06:16Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T05:06:16Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T05:06:25Z

This PR (HEAD: 9de82c2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/810660.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-08-05T05:25:17Z

Message from Vidhu Arora:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T16:36:46Z

Message from Keith Randall:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T16:36:46Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-05T16:05:49Z","revision":"8c7ccb8ca010a1add9164fd163bdd304e558cb24"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T16:55:45Z

Message from Keith Randall:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5200>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T16:55:46Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-misccompile has failed with summary (view all results):

go on master (change 810660)

Error: shard 1: error parsing and validating a sourceSpec from inputs to the build: gc.GetChange: rpc error: code = Internal desc = unexpected HTTP 500 from Gerrit

Additional links for debugging:

Shard 1 encountered a non-build/non-test failure, click here for the shard's build page

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T16:55:46Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T16:55:47Z

Message from Keith Randall:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T17:36:54Z

Message from Vidhu Arora:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T17:58:12Z

Message from Keith Randall:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T17:58:13Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-05T17:23:46Z","revision":"8c7ccb8ca010a1add9164fd163bdd304e558cb24"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T17:58:14Z

Message from Emmanuel Odeke:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T17:58:14Z

Message from Keith Randall:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5200>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T17:58:15Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-05T17:58:15Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

Use io.SeekStart, io.SeekCurrent, and io.SeekEnd constants in openFile.Seek instead of raw numeric literals. Also update the invalid whence test to use io.SeekEnd+5.

gopherbot · 2026-08-06T06:17:57Z

This PR (HEAD: a9f28f4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/810660.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-08-06T06:36:56Z

Message from Vidhu Arora:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T06:36:57Z

Message from Emmanuel Odeke:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T06:55:25Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-06T06:21:58Z","revision":"78e7ac6d3e71e4e499fd949709842adc7fe032b8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T06:55:25Z

Message from Emmanuel Odeke:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5137>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T06:55:26Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T06:55:27Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T15:38:09Z

Message from Keith Randall:

Patch Set 3: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T15:38:10Z

Message from Keith Randall:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-06T16:18:09Z

Message from Emmanuel Odeke:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/810660.
After addressing review feedback, remember to publish your drafts!

TheRodzz force-pushed the fix-embed-seek branch from 12024b0 to 9de82c2 Compare August 5, 2026 04:57

embed: use io.Seek constants in Seek whence switch and tests

a9f28f4

Use io.SeekStart, io.SeekCurrent, and io.SeekEnd constants in openFile.Seek instead of raw numeric literals. Also update the invalid whence test to use io.SeekEnd+5.

Uh oh!

Conversation

TheRodzz commented Aug 5, 2026

Uh oh!

google-cla Bot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 5, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

gopherbot commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants