Fix integer overflow in NHWC convolution kernel size calculation#10710
Open
YellowJune wants to merge 1 commit into
Open
Fix integer overflow in NHWC convolution kernel size calculation#10710YellowJune wants to merge 1 commit into
YellowJune wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
8c0f9f9 to
5a38dd1
Compare
qukhan
requested changes
Jul 13, 2026
5a38dd1 to
d8edbc1
Compare
qukhan
approved these changes
Jul 13, 2026
Author
|
Does the merge process automatically after copybara validation? Or, do you handle it manually after the full approval? |
Collaborator
|
It will process automatically. |
Author
However, I see that "1 workflow awaiting approval", which means task requires approval from a maintainer.. Can you please recheck about this? Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical integer overflow vulnerability in the NHWC convolution operator. The overflow occurred during the calculation of the kernel size (kernel_height * kernel_width), leading to incorrect microkernel selection and undersized heap memory allocation.
Problem
In src/operators/convolution-nhwc.c, the kernel size was calculated using 32-bit integer arithmetic before being widened to size_t. When the product of kernel_height and kernel_width exceeds 2^32 (e.g., 65536 x 65536), the value wraps to zero.
This zero-value propagates through the system, causing:
Fix
This fix aligns with previous security patches applied to deconvolution (#9876) and pooling/NCHW convolution (commit 32e57d1).
Verification Results