litert/tensor/arithmetic.h: bounds-check multiples length in Tile()#10772
Open
destro4evr-rgb wants to merge 1 commit into
Open
litert/tensor/arithmetic.h: bounds-check multiples length in Tile()#10772destro4evr-rgb wants to merge 1 commit into
destro4evr-rgb wants to merge 1 commit into
Conversation
Tile() resized output_info.shape to input_shape.size() (N) but iterated multiples_data.size() (M) times, causing heap OOB read/write when M > N. Add a length equality check mirroring the existing guard in Transpose().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tile()resizedoutput_info.shapetoinput_shape.size()(N elements) but iteratedmultiples_data.size()(M) times. When M > N,output_info.shape[i]andinput_shape[i]are both accessed out-of-bounds - a heap OOB write and OOB read on separatestd::vector<int>allocations.This adds a length equality check before the loop, matching the pattern already used in
Transpose()(added in #10702):Root cause
Tile()was introduced in #10464.Transpose()received the equivalent rank-equality guard in #10702 butTile()did not.Impact
A crafted LiteRT model with a
Tileop whose multiples tensor has more elements than the input tensor's rank triggers the OOB accesses during graph construction. The number of out-of-bounds writes isM - N, fully attacker-controlled.