use size_t for reduced input dims in reduce compute kernels#10779
Open
aizu-m wants to merge 1 commit into
Open
use size_t for reduced input dims in reduce compute kernels#10779aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with -Wshorten-64-to-32:
xnn_compute_contiguous_reduce and xnn_compute_discontiguous_reduce copy the reduced dimensions out of context->input_shape (a size_t array) into int locals, then use them as loop bounds. A reduced dimension of 2^31 or more truncates to a negative int. In
for (size_t i = 0; i < input_shape1; ++i)that negative value converts back to a near-2^64 bound, so the loop walks the input and output pointers well past their buffers. The discontiguous path also hands the truncated values straight to the size_t k2/k3 parameters of discontiguous_reduce2.Every other extent, stride and index in both functions is already size_t. These four locals were the only ones left as int. Changed them to match.