Skip to content

Remove a special case that supported ReflectionFreeAssertThrows. #8389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 28, 2026
+0 −18
Merged

Remove a special case that supported ReflectionFreeAssertThrows. #8389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions android/guava-testlib/src/com/google/common/testing/AbstractPackageSanityTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,15 +235,6 @@ public void testSerializable() throws Exception {
@Test
public void testNulls() throws Exception {
for (Class<?> classToTest : findClassesToTest(loadClassesInPackage(), NULL_TEST_METHOD_NAMES)) {
if (classToTest.getSimpleName().equals("ReflectionFreeAssertThrows")) {
/*
* These classes handle null properly but throw IllegalArgumentException for the default
* Class argument that this test uses. Normally we'd fix that by declaring a
* ReflectionFreeAssertThrowsTest with a testNulls method, but that's annoying to have to do
* for a package-private utility class. So we skip the class entirely instead.
*/
continue;
}
try {
tester.doTestNulls(classToTest, visibility);
} catch (Throwable e) {
Expand Down
9 changes: 0 additions & 9 deletions guava-testlib/src/com/google/common/testing/AbstractPackageSanityTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,15 +235,6 @@ public void testSerializable() throws Exception {
@Test
public void testNulls() throws Exception {
for (Class<?> classToTest : findClassesToTest(loadClassesInPackage(), NULL_TEST_METHOD_NAMES)) {
if (classToTest.getSimpleName().equals("ReflectionFreeAssertThrows")) {
/*
* These classes handle null properly but throw IllegalArgumentException for the default
* Class argument that this test uses. Normally we'd fix that by declaring a
* ReflectionFreeAssertThrowsTest with a testNulls method, but that's annoying to have to do
* for a package-private utility class. So we skip the class entirely instead.
*/
continue;
}
try {
tester.doTestNulls(classToTest, visibility);
} catch (Throwable e) {
Expand Down
Loading