Skip to content

Update npm scripts#4910

Closed
mh-cbon wants to merge 1 commit intogoogle:mdl-1.xfrom
mh-cbon:patch-1
Closed

Update npm scripts#4910
mh-cbon wants to merge 1 commit intogoogle:mdl-1.xfrom
mh-cbon:patch-1

Conversation

@mh-cbon
Copy link
Copy Markdown

@mh-cbon mh-cbon commented Nov 13, 2016

This fix allows to run npm test on a non en-en system.

On my system localized in french, previous script always failed.

[[ -z $(git status -uno --porcelain) ]] checks that local files are committed.

[[ -z $(git cherry -v) ]] checks there is no pending commits to push.

This fix allows to run npm test on a non en-en system.

On my system localized in french, previous script always failed.

`[[ -z $(git status -uno --porcelain) ]]` checks that local files are committed.

`[[ -z $(git cherry -v) ]]` checks there is no pending commits to push.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mh-cbon
Copy link
Copy Markdown
Author

mh-cbon commented Nov 13, 2016

won t sign the CLA, but you got the idea, right ?

@mh-cbon
Copy link
Copy Markdown
Author

mh-cbon commented Nov 14, 2016

see also google/web-starter-kit#799 its another variation.

@evieluvsrainbows
Copy link
Copy Markdown

evieluvsrainbows commented Nov 20, 2016

@mh-cbon you need to sign the CLA otherwise PRs won't be merged.

@mh-cbon
Copy link
Copy Markdown
Author

mh-cbon commented Nov 20, 2016

nop sorry.

@mh-cbon mh-cbon closed this Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants