Skip to content

ci: enforce warnings as errors in test entrypoints #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clydegerber wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

ci: enforce warnings as errors in test entrypoints #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/entrypoint-test-current.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ env
function run_cargo_test() {
env LD_LIBRARY_PATH="${ICU_LIBRARY_PATH}/lib" \
PKG_CONFIG_LIBDIR="${ICU_LIBRARY_PATH}/lib/pkgconfig" \
RUSTFLAGS="-D warnings" \
cargo test \
${_local_cargo_options} \
${CARGO_TEST_ARGS}
Expand All @@ -33,6 +34,7 @@ function run_cargo_test() {
function run_cargo_doc() {
env LD_LIBRARY_PATH="${ICU_LIBRARY_PATH}/lib" \
PKG_CONFIG_LIBDIR="${ICU_LIBRARY_PATH}/lib/pkgconfig" \
RUSTFLAGS="-D warnings" \
cargo doc ${_local_cargo_options} ${CARGO_TEST_ARGS}
}

Expand Down
4 changes: 2 additions & 2 deletions build/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ readonly __all_dirs="$(ls -d rust_icu_*)"
env

function run_cargo_test() {
env LD_LIBRARY_PATH="/usr/local/lib" cargo test ${CARGO_TEST_ARGS}
env LD_LIBRARY_PATH="/usr/local/lib" RUSTFLAGS="-D warnings" cargo test ${CARGO_TEST_ARGS}
}

function run_cargo_doc() {
env LD_LIBRARY_PATH="/usr/local/lib" cargo doc ${CARGO_TEST_ARGS}
env LD_LIBRARY_PATH="/usr/local/lib" RUSTFLAGS="-D warnings" cargo doc ${CARGO_TEST_ARGS}
}

# Running cargo test or doc in the top level directory actually does nothing.
Expand Down