chore: rename Google.Developers.Knowledge.V1 to Google.Developers.DeveloperKnowledge.V1#15642
Merged
Merged
Conversation
…eloperKnowledge.V1 Regenerates with the latest API specifications.
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the namespace and package from Google.Developers.Knowledge.V1 to Google.Developers.DeveloperKnowledge.V1 across project files, generated snippets, and metadata configurations. A review comment correctly points out that the snippet metadata JSON filename itself should also be renamed to reflect this package change.
| { | ||
| "clientLibrary": { | ||
| "name": "Google.Developers.Knowledge.V1", | ||
| "name": "Google.Developers.DeveloperKnowledge.V1", |
Contributor
Collaborator
Author
There was a problem hiding this comment.
No, it's named based on the protobuf package.
https://github.com/googleapis/gapic-generator-csharp/blob/main/Google.Api.Generator/CodeGenerator.cs#L519
amanda-tarafa
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates with the latest API specifications.