Skip to content

fix(vertex): convert GoogleSearch excludeDomains to camelCase#2299

Open
MukundaKatta wants to merge 3 commits intogoogleapis:mainfrom
MukundaKatta:codex/python-genai-vertex-exclude-domains
Open

fix(vertex): convert GoogleSearch excludeDomains to camelCase#2299
MukundaKatta wants to merge 3 commits intogoogleapis:mainfrom
MukundaKatta:codex/python-genai-vertex-exclude-domains

Conversation

@MukundaKatta
Copy link
Copy Markdown

Summary

  • restore explicit Vertex conversion for Tool.google_search
  • camel-case exclude_domains to excludeDomains in Vertex requests
  • add a regression test that checks the serialized Vertex tool payload directly

Testing

  • python3 -m py_compile google/genai/models.py google/genai/tests/models/test_generate_content.py
  • python3 -m pytest google/genai/tests/models/test_generate_content.py -k "exclude_domains_is_camel_cased" (not run successfully locally: test import fails because google.auth is not installed in this environment)

@Venkaiahbabuneelam Venkaiahbabuneelam self-assigned this Apr 21, 2026
@Venkaiahbabuneelam Venkaiahbabuneelam added the size:L Code changes between 40-100 lines label Apr 21, 2026
@Venkaiahbabuneelam
Copy link
Copy Markdown

Hi @MukundaKatta, Thanks for reaching out us!

It looks like some checks failed. Kindly resolve the conflicts.

Thanks

@MukundaKatta MukundaKatta changed the title Convert Vertex GoogleSearch exclude domains fix(vertex): convert GoogleSearch excludeDomains to camelCase Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L Code changes between 40-100 lines status:awaiting user response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants