Skip to content

fix(chats): preserve zero-valued config overrides#2302

Open
MukundaKatta wants to merge 2 commits intogoogleapis:mainfrom
MukundaKatta:codex/python-genai-chat-zero-temp
Open

fix(chats): preserve zero-valued config overrides#2302
MukundaKatta wants to merge 2 commits intogoogleapis:mainfrom
MukundaKatta:codex/python-genai-chat-zero-temp

Conversation

@MukundaKatta
Copy link
Copy Markdown

Summary

  • preserve explicit chat request configs like instead of falling back to the chat default config
  • apply the same fix to sync and async chat streaming paths, which used the same falsy check
  • add regression tests for sync and async send_message/send_message_stream zero-temperature overrides

Testing

  • python3 -m py_compile google/genai/chats.py google/genai/tests/chats/test_send_message.py
  • python3 -m pytest google/genai/tests/chats/test_send_message.py -k "zero_temperature_override" (fails during collection locally: )

@Venkaiahbabuneelam Venkaiahbabuneelam self-assigned this Apr 20, 2026
@Venkaiahbabuneelam Venkaiahbabuneelam added the size:XL Code changes > 100 lines label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL Code changes > 100 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants