Skip to content

fix(models): serialize multimodal function response display names #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MukundaKatta wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(models): serialize multimodal function response display names #2305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c1826a
fix(models): serialize multimodal function response display names
MukundaKatta Apr 20, 2026
e73ebe0
Merge branch 'main' into codex/python-genai-function-response-display…
MukundaKatta Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions google/genai/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3429,10 +3429,15 @@ def _Part_to_mldev(
)

if getv(from_object, ['function_response']) is not None:
function_response = getv(from_object, ['function_response'])
if isinstance(function_response, dict):
function_response = types.FunctionResponse.model_validate(
function_response
)
setv(
to_object,
['functionResponse'],
getv(from_object, ['function_response']),
function_response.model_dump(by_alias=True, exclude_none=True, mode='json'),
)

if getv(from_object, ['inline_data']) is not None:
Expand Down Expand Up @@ -3500,10 +3505,15 @@ def _Part_to_vertex(
setv(to_object, ['functionCall'], getv(from_object, ['function_call']))

if getv(from_object, ['function_response']) is not None:
function_response = getv(from_object, ['function_response'])
if isinstance(function_response, dict):
function_response = types.FunctionResponse.model_validate(
function_response
)
setv(
to_object,
['functionResponse'],
getv(from_object, ['function_response']),
function_response.model_dump(by_alias=True, exclude_none=True, mode='json'),
)

if getv(from_object, ['inline_data']) is not None:
Expand Down
23 changes: 23 additions & 0 deletions google/genai/tests/types/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import PIL.Image
import pydantic
import pytest
from ... import models
from ... import types

_is_mcp_imported = False
Expand Down Expand Up @@ -115,6 +116,28 @@ def test_factory_method_part_from_function_response_with_multi_modal_parts():
assert isinstance(my_part, SubPart)


def test_part_to_mldev_serializes_function_response_display_name():
my_part = SubPart.from_function_response(
name='get_image',
response={'image_ref': {'$ref': 'instrument.jpg'}},
parts=[
{
'inline_data': {
'data': b'123',
'mime_type': 'image/jpeg',
'display_name': 'instrument.jpg',
}
}
],
)

serialized = models._Part_to_mldev(my_part)

assert serialized['functionResponse']['parts'][0]['inlineData'][
'displayName'
] == 'instrument.jpg'


def test_factory_method_function_response_part_from_bytes():
my_part = SubFunctionResponsePart.from_bytes(
data=b'123', mime_type='image/png'
Expand Down