Skip to content

Change 'Old/New' to 'Before/After' #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simoncozens merged 2 commits into from
Apr 7, 2026
+8 −8
Merged

Change 'Old/New' to 'Before/After' #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
389017e
Change 'Old/New' to 'Before/After'
davelab6 Apr 7, 2026
a919818
Update navigation items in index.html
davelab6 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions diffenator3-web/www/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ <h2>Font after</h2>

<div class="container">
<div id="ui-nav">
<div class="ui-nav-item" id="fonttoggle">Old</div>
<div class="ui-nav-item" id="fontanimate">Animate</div>
<div class="ui-nav-item" id="fonttoggle">Before</div>
<div class="ui-nav-item" id="fontanimate">Animate!</div>
<div id="axes"></div>
</div>

Expand Down
12 changes: 6 additions & 6 deletions diffenator3-web/www/ts/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function diffLanguages(report: Record<string, LanguageDiff>) {
return;
}
$("#difflanguages").append(
`<table class="table table-striped" id="difflanguages"><tr><th>Language</th><th>Old</th><th>New</th></tr></table>`
`<table class="table table-striped" id="difflanguages"><tr><th>Language</th><th>Before</th><th>After</th></tr></table>`
);
for (let [name, diff] of notSame) {
let row = $("<tr>");
Expand Down Expand Up @@ -356,7 +356,7 @@ function diffKerns(report: Report) {
`<h3 class="border-top pt-2 border-dark-subtle">Modified Kerns</h3>`
);
$("#diffkerns").append(
`<table class="table table-striped" id="diffkerns"><tr><th>Pair</th><th>Old</th><th>New</th></tr></table>`
`<table class="table table-striped" id="diffkerns"><tr><th>Pair</th><th>Before</th><th>After</th></tr></table>`
);
for (let [pair, value] of Object.entries(report["kerns"])) {
if (pair == "error") {
Expand Down Expand Up @@ -444,7 +444,7 @@ function cmapDiff(cmap_diff: CmapDiff | undefined) {
);
if (cmap_diff && (cmap_diff.new || cmap_diff.missing)) {
if (cmap_diff.new) {
$("#cmapdiff").append(`<h4>Added Glyphs</h4>`);
$("#cmapdiff").append(`<h4>Added Glyphs</h4><p>Be sure to look at the 'after' because the 'before' will likely show tofu</p>`);
let added = $("<div>");
for (let glyph of cmap_diff.new) {
addAGlyph(glyph, added);
Expand All @@ -467,11 +467,11 @@ function cmapDiff(cmap_diff: CmapDiff | undefined) {

function setupAnimation() {
$("#fonttoggle").click(function () {
if ($(this).text() == "Old") {
$(this).text("New");
if ($(this).text() == "Before") {
$(this).text("After");
$(".font-before").removeClass("font-before").addClass("font-after");
} else {
$(this).text("Old");
$(this).text("Before");
$(".font-after").removeClass("font-after").addClass("font-before");
}
});
Expand Down
Loading