-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(helpers): respect --format flag in sheets +append, +read, and docs +write #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
nuthalapativarun
wants to merge
4
commits into
googleworkspace:main
from
nuthalapativarun:fix/helpers-format-flag
+33
−9
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5b73417
fix(helpers): respect --format flag in sheets +append, +read, and doc…
nuthalapativarun 6dbe0ba
fixup: read --format from parent ArgMatches; avoid variable shadowing
nuthalapativarun 563087c
fixup: revert sub_matches rename; read format and dry-run from subcom…
nuthalapativarun 8334dbf
fixup: use sub_matches for subcommand args; read global flags from pa…
nuthalapativarun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| "@googleworkspace/cli": patch | ||
| --- | ||
|
|
||
| Fix `--format` flag being silently ignored in sheets and docs helpers | ||
|
|
||
| `sheets +append`, `sheets +read`, and `docs +write` all hard-coded | ||
| `OutputFormat::default()` (JSON) when calling `executor::execute_method`, | ||
| meaning `--format table`, `--format yaml`, and `--format csv` had no effect. | ||
| The handlers now read the global `--format` flag from `ArgMatches` and pass | ||
| it through to the executor, consistent with how `calendar +agenda` and | ||
| `gmail +triage` already behave. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.