Add locking for BaseThread start/stop#1155
Draft
nascheme wants to merge 1 commit into
Draft
Conversation
Use a lock and event to ensure that BaseThread.start() and BaseThread.stop() work reliability when called in different orders or concurrently from different threads.
Collaborator
|
Are you working on it @nascheme? Since the PR is in draft, I didn't merge yet. |
Contributor
Author
|
For now, no I'm not. I'm hoping to get back to working on "watchdog" but that might be a while. So, if someone wants to take over this PR or make their own, feel free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a lock and event to ensure that BaseThread.start() and BaseThread.stop() work reliability when called in different orders or concurrently from different threads.
This should resolve the race reported in #1044. This is not sufficient to allow pytest-run-parallel to pass with the free-threaded build. That will require some additional locking or race condition fixes in addition to this PR.