fix: escape square brackets in patterns to match literal bracket file…#1173
Open
koteshyelamati wants to merge 1 commit into
Open
fix: escape square brackets in patterns to match literal bracket file…#1173koteshyelamati wants to merge 1 commit into
koteshyelamati wants to merge 1 commit into
Conversation
…names Square brackets in patterns (e.g. "[test].txt") were being interpreted as character classes by fnmatch/pathlib, causing the pattern to match files like "t.txt" instead of a file literally named "[test].txt". Fix by replacing "[" with "[[[]" in the pattern before matching, which makes the bracket literal in fnmatch/glob syntax. Fixes gorakhargosh#991
Collaborator
|
Can you add regression tests? |
Author
|
Yes @BoboTiG — adding regression tests for literal-bracket patterns, pushing to this branch shortly. |
Collaborator
|
Hmm this way it will be no more possible to use character classes. 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Square brackets in watchdog patterns (e.g.
[test].txt) were being interpreted as fnmatch character classes, causing:[test].txtmatchest.txt✗ (wrong —[test]treated as a char class)[test].txtdoes NOT match[test].txt✗ (wrong — literal file not detected)Root Cause
_full_match()delegates topathlib.PurePath.full_match()(Python ≥ 3.13) or thetranslate()fallback, both of which use fnmatch-style glob patterns where[…]denotes a character class.Fix
Before pattern matching, replace
[with[[[]so the bracket is literal in fnmatch/glob syntax. This makes[test].txtcorrectly match a file literally named[test].txt.Fixes #991