Skip to content

Add separate method for file/directory metadata modifcation#800

Open
GreatBahram wants to merge 43 commits into
gorakhargosh:masterfrom
GreatBahram:add-attributes-only
Open

Add separate method for file/directory metadata modifcation#800
GreatBahram wants to merge 43 commits into
gorakhargosh:masterfrom
GreatBahram:add-attributes-only

Conversation

@GreatBahram

Copy link
Copy Markdown

Hi there,

As we discussed here #260, I tried to solve the problem using two new events for inotify, kqueue, and fsevents2 backends. So far, I've found no solution for the windows, as in this document describes it does not have an action for this purpose.

@GreatBahram GreatBahram force-pushed the add-attributes-only branch from bbb72a0 to 3b6f258 Compare June 10, 2021 14:59
To be able to run it manually, currently it only works when you send a pull_request
Comment thread .github/workflows/tests.yml
@GreatBahram

Copy link
Copy Markdown
Author

Hi @BoboTiG,

Could you approve my workflows, please?

I changed the fsevents and fsevents2 modules, but I'm still unsure of them. The GitHub actions is very primitive; I could not get any guarantee out of it. But for inofity and kqueue, I tested them manually on Linux and Freebsd.

I’m eager to receive your feedback.

@GreatBahram

Copy link
Copy Markdown
Author

The pipeline gives a bizarre error message. Do you know what the reason is?

OSError: [Errno 9] Bad file descriptor

@BoboTiG

BoboTiG commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

@GreatBahram I fixed conflicts, and rebased from master. Would you be able to double check I didn't alter what you've done in tests + fix linting/mypy issues 🙏🏻 ?

@mmguero

mmguero commented Apr 6, 2023

Copy link
Copy Markdown

Glad to see this PR is still alive, I'd love to see this get pulled.

Comment thread tests/shell.py Outdated
Comment thread src/watchdog/events.py
Comment thread src/watchdog/events.py
Comment thread src/watchdog/observers/fsevents.py Outdated
Comment thread src/watchdog/observers/fsevents.py Outdated
Comment thread src/watchdog/observers/fsevents.py Outdated
@BoboTiG

BoboTiG commented Apr 22, 2023

Copy link
Copy Markdown
Collaborator

Several Mac, and Windows, tests are failing. I'l try to fix them later. I would like to have that PR merged for the upcoming version.

Comment thread tests/test_fsevents.py Outdated
Comment thread tests/test_emitter.py Outdated
Comment thread tests/utils.py
Comment thread tests/test_emitter.py Outdated
Comment thread tests/utils.py Outdated
@BoboTiG

BoboTiG commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

A few remaining macOS tests to fix, and we will be good to merge.

@BoboTiG

BoboTiG commented May 14, 2023

Copy link
Copy Markdown
Collaborator

I finally have a Mac machine, it will be easier to fix those tests. I'll try to get it done "quickly".

Comment thread tests/test_emitter.py Outdated
Comment thread tests/test_emitter.py Outdated
Comment thread tests/test_emitter.py Outdated
Comment thread tests/test_emitter.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants