Skip to content

Adding Support for site_name - #156

Open
tkz79 wants to merge 1 commit into
gottfrois:masterfrom
retailzipline:add-support-for-sitename
Open

Adding Support for site_name#156
tkz79 wants to merge 1 commit into
gottfrois:masterfrom
retailzipline:add-support-for-sitename

Conversation

@tkz79

@tkz79 tkz79 commented Aug 16, 2023

Copy link
Copy Markdown

Adds support for a site_name field

Note: first time contributing to someone else's repo... may not have done this right.... 🤞🏼

@gottfrois

Copy link
Copy Markdown
Owner

Looks good! Can you maybe add a spec by adding an example of an HTML page with this site_name attribute to make sure it's parsed correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants