fix(logql): Handle nil entry in blocked queries slice#21735
Open
fix(logql): Handle nil entry in blocked queries slice#21735
nil entry in blocked queries slice#21735Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an edge case where a
nilentry in the blocked queries slice leads to a nil-pointer dereference during execution.When the blocked queries slice is generated through the tenant limits, this should never be the case.
Note
Low Risk
Low risk: adds a defensive nil check in the blocked-query loop and a regression test; no behavior changes for valid policies.
Overview
Prevents a nil-pointer panic when the
BlockedQueriesslice containsnilby skipping nil entries during evaluation.Adds a unit test covering this edge case to ensure queries execute normally when a nil policy is present.
Reviewed by Cursor Bugbot for commit 95c1c78. Bugbot is set up for automated code reviews on this repo. Configure here.