fix(compactor): skip retention scans for zero retention#21756
Open
u-kai wants to merge 1 commit intografana:mainfrom
Open
fix(compactor): skip retention scans for zero retention#21756u-kai wants to merge 1 commit intografana:mainfrom
u-kai wants to merge 1 commit intografana:mainfrom
Conversation
Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes retention scan planning so a retention period of
0is treated as disabled when computingthe latest retention start time.
Which issue(s) this PR fixes:
Fixes #21755
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PRNote
Medium Risk
Changes how retention cutoffs are computed when retention is set to
0, which can affect whether index tables are scanned for deletions and could unintentionally skip/perform scans if miscomputed.Overview
Treats retention periods of
0(or non-positive) as retention disabled when planning compactor retention scans.findLatestRetentionStartTimenow ignores non-positive stream retention values, avoids computing negative cutoffs when defaults/users have retention disabled, and records per-tenant disabled retention as0soIntervalMayHaveExpiredChunkswon’t fall back to default retention.Expands unit tests to cover zero-retention combinations for default, stream-level, and per-tenant retention, including ensuring disabled per-tenant retention does not trigger index scans.
Reviewed by Cursor Bugbot for commit a3a2d30. Bugbot is set up for automated code reviews on this repo. Configure here.