feat!: Update cmake to 4.1.2#2
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think the diff is very helpful for a code review on this pr it's probably better to check my changes here Kitware/CMake@master...spotandjake:CMake:master
I reforked cmake from the latest release
4.1.2and applied the same changes that make this patch for3.27.4work. The advantage of this is better compatbility with newer toolchains such as the latest version of clang.This seems like a better way of fixing the clang 17 issues we fixed in #1
We don't really have tests setup for this repo so I added a basic test to build with esy and verified that our upstream libbinaryen builds here: https://github.com/spotandjake/libbinaryen/actions/runs/18693766744/job/53305778962
I'm not entirely sure what the best way to merge this is, ideally we would just force ignore the conflicts here as they have different roots.