chore(compiler): Update OCaml to 4.14 & update dependencies#1547
Merged
chore(compiler): Update OCaml to 4.14 & update dependencies#1547
Conversation
ospencer
approved these changes
Dec 14, 2022
Member
ospencer
left a comment
ospencer
left a comment
There was a problem hiding this comment.
Truly excellent work; let's get this over the line!!
peblair
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the compiler to use OCaml 4.14 - this required forking https://github.com/esy-ocaml/ocaml and updating flexdll to 0.42 which supports the
-l:linker flag—submitted upstream as esy-ocaml/ocaml#63. We needed this because OCaml 4.12.1+ made changes related to MinGW and no longer supports passing the-staticflag.I also updated dependencies while I was making changes to the OCaml stuff.
This also fixes the issue with Grain failing to build on newer GCC because that was fixed in the upstream OCaml (we didn't have an issue).
I didn't port over @ospencer's cleanup from #1345 but we can rebase that one and just use it for the cleanup stuff.