feat(runtime): Move Memory.compare from compiler to runtime#2376
Open
spotandjake wants to merge 1 commit intograin-lang:oscar/gc-rebasedfrom
Open
feat(runtime): Move Memory.compare from compiler to runtime#2376spotandjake wants to merge 1 commit intograin-lang:oscar/gc-rebasedfrom
Memory.compare from compiler to runtime#2376spotandjake wants to merge 1 commit intograin-lang:oscar/gc-rebasedfrom
Conversation
spotandjake
requested review from
alex-snezhko,
marcusroberts and
phated
as code owners
Member
|
Want to rebase this off of the GC branch? |
This pr removes our `@wasm.memory_compare` primitive in favour of implementing it in the runtime. The reason I am making this change, is as we move away from linear memory and towards wasm gc it isn't as important that this function is in the compiler. Removing it from compcore lowers our maintance burden and moving it to grain makes it easier to manage. The bigger motivator is that our primitives tend to represent either low level things that aren't practical todo in the language itself or things with a direct wasm instruction and this fits neither of those, making the runtime a better home. Similar to how we handle all of the gc array comparisons once that pr lands. I'm not sure if we actually want to go forward with this change or not so i'm really just putting this pr in the case we do. Closes: grain-lang#2375
spotandjake
force-pushed
the
spotandjake/memory_compare
branch
from
e85eaec to
a7d5ed4
Compare
Member
Author
Made that change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr removes our
@wasm.memory_compareprimitive in favour of implementing it in the runtime.The reason I am making this change, is as we move away from linear memory and towards wasm gc it isn't as important that this function is in the compiler. Removing it from compcore lowers our maintance burden and moving it to grain makes it easier to manage. The bigger motivator is that our primitives tend to represent either low level things that aren't practical todo in the language itself or things with a direct wasm instruction and this fits neither of those, making the runtime a better home. Similar to how we handle all of the gc array comparisons once that pr lands.
I'm not sure if we actually want to go forward with this change or not so i'm really just putting this pr in the case we do.
Notes:
-1or1we now return the magnitude of the difference, this fits the compare api however it is a slight change to the logic we had before.memory.grI can move those to a seperate pr but I figured if i'm testing one I might as well test the things it relies on.Closes: #2375