Skip to content

fix(lsp): make spec complient JSON-RPC response and properly implement definition link suport#2392

Open
Kara-Zor-El wants to merge 4 commits intograin-lang:mainfrom
Kara-Zor-El:Kara-Zor-El/lsp-fix
Open

fix(lsp): make spec complient JSON-RPC response and properly implement definition link suport#2392
Kara-Zor-El wants to merge 4 commits intograin-lang:mainfrom
Kara-Zor-El:Kara-Zor-El/lsp-fix

Conversation

@Kara-Zor-El
Copy link
Copy Markdown
Contributor

@Kara-Zor-El Kara-Zor-El commented May 2, 2026

Howdy,

I'm working on making a Neovim plugin for the LSP and I got some errors, when looking into them I discovered there was some issues with the LSP:

sorry for how link dense the links are 🥲

Copy link
Copy Markdown
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me just two nits

Comment thread compiler/src/language_server/goto.re Outdated
Comment thread compiler/src/language_server/initialize.re Outdated
Copy link
Copy Markdown
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants