fix(lsp): make spec complient JSON-RPC response and properly implement definition link suport#2392
Open
Kara-Zor-El wants to merge 4 commits intograin-lang:mainfrom
Open
fix(lsp): make spec complient JSON-RPC response and properly implement definition link suport#2392Kara-Zor-El wants to merge 4 commits intograin-lang:mainfrom
Kara-Zor-El wants to merge 4 commits intograin-lang:mainfrom
Conversation
spotandjake
reviewed
May 2, 2026
Member
spotandjake
left a comment
There was a problem hiding this comment.
Looks great to me just two nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howdy,
I'm working on making a Neovim plugin for the LSP and I got some errors, when looking into them I discovered there was some issues with the LSP:
sorry for how link dense the links are 🥲