Skip to content

ci/tests: handle known issues as expected failures#325

Merged
dorchard merged 2 commits into
granule-project:mainfrom
jacobpake:tests-recognise-known-issues
Apr 20, 2026
Merged

ci/tests: handle known issues as expected failures#325
dorchard merged 2 commits into
granule-project:mainfrom
jacobpake:tests-recognise-known-issues

Conversation

@jacobpake
Copy link
Copy Markdown
Member

Individual tests listed in .known-issues no longer effect the overall test suite failure state.

These tests are still run and their errors are still emitted, along with the associated issue number, e.g.

frontend/tests/cases/positive/indexed/infer-kinds.gr:                                         FAIL (expected: #299)
      Exception: Type checking failed:
      Kind mismatch: frontend/tests/cases/positive/indexed/infer-kinds.gr:10:1:
      Expected kind `Type 2` for type `Coeffect` but actual kind is `Type`
      CallStack (from HasCallStack):
        error, called at interpreter/tests/Golden.hs:152:21 in main:Main (expected failure)

This allows us to have meaningful CI status checks without removing the tests. Ideally, we should be able to remove these changes once all issues are resolved.

@jacobpake jacobpake linked an issue Apr 3, 2026 that may be closed by this pull request
16 tasks
@dorchard
Copy link
Copy Markdown
Member

That's cool - thanks for this! We can fix those remaining ones hopefully at the next hackathon!

@dorchard dorchard merged commit 130893e into granule-project:main Apr 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test checklist

2 participants